Add option to hide buckets from summaries #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a new option to the bucket settings to exclude the bucket from summaries on the report page. Previously large single transactions which are not part of my monthly budget (like selling stocks) completly messed up my statistics. Im also changing how transfer transactions are displayed. They are now hidden from the summaries to fix the statistics when the "input" and "output" transactions of a transfer are in different months. Discrepancies in the transfer bucket can still be seen in the "Data Consistency" tab.
Owner
|
Looking good. Thanks a lot for your contribution, I will later have a deeper look on it. Is it possible for you to also add a Db Migration for PostgreSQL? Otherwise I can do it later from my side, too. |
Contributor
Author
|
Hi, yes, I added a migration for postgres. The sqlite provider is no longer supported, right? |
Owner
|
Thanks a lot, correct SQLite is no longer supported |
TheAxelander
requested changes
Apr 5, 2025
Owner
TheAxelander
left a comment
TheAxelander
left a comment
There was a problem hiding this comment.
I added some comments and some ideas. Let me know what you think.
Overall I think this a great idea, which solves a common problem that I also came across how to exclude certain exceptional Transactions that mess up the reports.
OpenBudgeteer.Core.Data.Repository/BudgetedTransactionRepository.cs
Outdated
Show resolved
Hide resolved
OpenBudgeteer.Core/ViewModels/PageViewModels/ReportPageViewModel.cs
Outdated
Show resolved
Hide resolved
OpenBudgeteer.Core/ViewModels/PageViewModels/ReportPageViewModel.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to the bucket settings to exclude the bucket from summaries on the report page. Previously large single transactions which are not part of my monthly budget (like selling stocks) completly messed up my statistics.
Im also changing how transfer transactions are displayed. They are now hidden from the summaries to fix the statistics when the "input" and "output" transactions of a transfer are in different months. Discrepancies in the transfer bucket can still be seen in the "Data Consistency" tab.