Skip to content

Conversation

@andrewginns
Copy link

@andrewginns andrewginns commented Dec 7, 2025

Related GitHub Issue

Closes: #9891

Description

  • Adds "xhigh" to the reasoning effort setting schema and model capabilities
  • Exposes "xhigh" only for gpt-5.1-codex-max in openAiNativeModels
  • Adds an OpenAI Native test asserting the Responses request includes reasoning,effort: "xhigh"

Test Procedure

  • pnpm --filter roo-cline test -- api/providers/__tests__/openai-native.spec.ts

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Dec 7, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 7, 2025

Rooviewer Clock   See task on Roo Cloud

Re-review completed. The localization commit properly translates "Extra high" reasoning effort label across all 17 supported languages. All translations are semantically accurate and consistent with the existing implementation.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 7, 2025
@andrewginns
Copy link
Author

@roomote review the localisation translations

@roomote
Copy link
Contributor

roomote bot commented Dec 7, 2025

Fixaroo Clock   Follow along on Roo Cloud

Working on reviewing the localization translations for the "xhigh" reasoning effort setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add xhigh reasoning to OpenAI gpt5.1-codex-max

2 participants