Skip to content

Conversation

@Dinesh-Gautam
Copy link

@Dinesh-Gautam Dinesh-Gautam commented Dec 6, 2025

Related GitHub Issue

Closes: #9886

Description

This PR fixes an issue where a parent task would not be reopened if the user explicitly terminated a delegated child task

The fix introduces a check to see if the current task has a parentTaskId If it does, instead of clearing the task, it now calls reopenParentFromDelegation with a summary. This summary is derived from the last completion_result message in the child task's history, or defaults to "Canceled" if no completion message is found i.e the user clicked the Terminate button.


Important

Fix task handling in webviewMessageHandler.ts to reopen parent task with a summary if a subtask is terminated by the user.

  • Behavior:
    • In webviewMessageHandler.ts, modify clearTask handling to check for parentTaskId.
    • If parentTaskId exists, call reopenParentFromDelegation with a summary from the last completion_result message or default to "Canceled".
    • If no parentTaskId, proceed with clearTask as usual.

This description was created by Ellipsis for 4d45424. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Dec 6, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 6, 2025

Rooviewer Clock   See task on Roo Cloud

✅ Review completed - no issues found

The implementation correctly addresses issue #9886 by checking for a parent task when the user terminates a subtask and properly calling reopenParentFromDelegation to resume the parent task. The changes follow the existing delegation flow pattern and handle edge cases appropriately.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Terminating an active subtask fails to resume the parent task

2 participants