FIX: Reopen parent task if subtask is terminated by the user #9887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #9886
Description
This PR fixes an issue where a parent task would not be reopened if the user explicitly terminated a delegated child task
The fix introduces a check to see if the current task has a
parentTaskIdIf it does, instead of clearing the task, it now callsreopenParentFromDelegationwith a summary. This summary is derived from the lastcompletion_resultmessage in the child task's history, or defaults to "Canceled" if no completion message is found i.e the user clicked theTerminatebutton.Important
Fix task handling in
webviewMessageHandler.tsto reopen parent task with a summary if a subtask is terminated by the user.webviewMessageHandler.ts, modifyclearTaskhandling to check forparentTaskId.parentTaskIdexists, callreopenParentFromDelegationwith a summary from the lastcompletion_resultmessage or default to "Canceled".parentTaskId, proceed withclearTaskas usual.This description was created by
for 4d45424. You can customize this summary. It will automatically update as commits are pushed.