Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Dec 6, 2025

Fixes the checkpoint initialization warning message to display the user's configured timeout value instead of the hardcoded 5-second warning threshold.

Changes:

  • Updated src/core/checkpoints/index.ts to pass task.checkpointTimeout (configured value) instead of WARNING_THRESHOLD_MS / 1000 (hardcoded 5 seconds)
  • Updated tests in checkpoint.test.ts to verify the warning uses the configured timeout value

Before:
User sets checkpoint timeout to 30 seconds in settings, but warning shows "Waited 5 seconds for checkpoint initialization..."

After:
Warning correctly shows "Waited 30 seconds for checkpoint initialization..." when user has configured 30 seconds


View task on Roo Code Cloud


Important

Update checkpoint warning to use user-configured timeout in index.ts and update tests in checkpoint.test.ts.

  • Behavior:
    • Update getCheckpointService in index.ts to use task.checkpointTimeout for warning messages instead of WARNING_THRESHOLD_MS.
    • Warning message now reflects user-configured timeout value.
  • Tests:
    • Update checkpoint.test.ts to test warning message with configured timeout value.
    • Add tests to verify correct timeout conversion and i18n key usage.

This description was created by Ellipsis for d85a5f2. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Contributor Author

roomote bot commented Dec 6, 2025

Rooviewer Clock   See task on Roo Cloud

Re-review complete. All previously flagged issues have been resolved. The changes correctly implement the fix to use the configured timeout value for both the warning condition and the warning message.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 6, 2025
@hannesrudolph hannesrudolph marked this pull request as ready for review December 6, 2025 01:23
@hannesrudolph hannesrudolph requested review from cte and jr as code owners December 6, 2025 01:23
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 6, 2025
@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Dec 6, 2025
@dosubot dosubot bot added the bug Something isn't working label Dec 6, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Dec 6, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. The changes correctly implement the fix to use the configured timeout value for both the warning condition and the warning message. All tests have been updated appropriately.

Summary:

  • Warning now appears at the user's configured timeout (e.g., 15 seconds) instead of hardcoded 5 seconds
  • Warning message displays the user's configured timeout value
  • Tests verify the new behavior

No issues found.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PR - Needs Preliminary Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: PR [Needs Prelim Review]

Development

Successfully merging this pull request may close these issues.

4 participants