fix: use json-stream-stringify for pretty-printing MCP config files #9863
+47
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #9862 by implementing the suggestion from @Michaelzag to use
json-stream-stringifyinstead of the built-inJSON.stringifyfor pretty-printing MCP configuration files.Problem
The
safeWriteJson()utility was usingstream-jsonwhich only outputs compact/minified JSON, making configuration files like.roo/mcp.jsondifficult to read and manually edit after being modified through the UI.Solution
stream-jsonwithjson-stream-stringifylibrary which supports streaming pretty-printingprettyPrintoption to thesafeWriteJson()function{ prettyPrint: true }Changes
src/utils/safeWriteJson.tsto useJsonStreamStringifywith optional indentationsrc/services/mcp/McpHub.tsto pass{ prettyPrint: true }for all config writessrc/core/webview/webviewMessageHandler.tsto use pretty-printing for project MCP settingsjson-stream-stringifyas a dependencyBenefits
Testing
safeWriteJsontest suite runs successfullyFixes #9862
Feedback and guidance are welcome!