fix: bypass maxReadFileLine for @ mentioned files #9841
+5
−113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where @ mentioned files were silently truncated according to the maxReadFileLine setting.
Changes
When a user explicitly @ mentions a file (e.g.,
@src/file.ts), they expect to see the full content regardless of themaxReadFileLinesetting. This PR ensures that @ mentioned files always bypass the auto-truncate threshold by passing-1(unlimited) toextractTextFromFile.Modified Files
src/core/mentions/index.ts: UpdatedgetFileOrFolderContentto always pass-1for individual file mentionssrc/core/mentions/index.ts: Updated folder mention file reading to always pass-1Behavior
maxReadFileLinetruncation (silently)maxReadFileLinesetting (unchanged)Testing
All existing tests pass:
View task on Roo Code Cloud