Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 24, 2023

Fixes #7065

Description

Remove self.weight in DiceLoss and FocalLoss

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu mentioned this pull request Oct 24, 2023
7 tasks
@KumoLiu KumoLiu requested review from myron and wyli October 24, 2023 03:37
Signed-off-by: KumoLiu <[email protected]>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Oct 24, 2023

/build

@wyli wyli enabled auto-merge (squash) October 24, 2023 07:50
@wyli
Copy link
Contributor

wyli commented Oct 24, 2023

/build

@wyli wyli merged commit cc20c9b into Project-MONAI:dev Oct 24, 2023
@KumoLiu KumoLiu deleted the weight branch October 25, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DiceLoss add weight per class parameter

2 participants