Session management #102
Merged
Session management #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove logged_on attribute from user schema, add a concurrency limit - add session schema, one user to many sessions - add a SessionSupervisor to hook into the server lifecycle and do cleanup - add a SessionManager responsible for manipulating the session table - fix repocase to ensure the database doesn't shutdown till the test completes - update test_helper
# Conflicts: # apps/server/lib/prodigy/server/service/messaging.ex
Session is now a persistent record of when users sessions begin and end (and thus which are presently active), and Context was chosen to represent the ephemeral details that are necessary to the operation of the service during a single user connection.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors session management from a simple boolean flag to a proper database table with support for concurrent sessions.
- Replaced user-level
logged_onboolean with a dedicated session table - Added configurable concurrency limits per user (default: 1, 0 for unlimited)
- Renamed
SessiontoContextto better reflect ephemeral connection state
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/server/lib/prodigy/server/session_manager.ex | New module for managing user sessions with concurrency control |
| apps/server/lib/prodigy/server/session_cleanup.ex | New GenServer for cleaning up sessions on shutdown |
| apps/core/priv/repo/migrations/20250908221355_create_sessions.exs | Database migration creating session table and removing logged_on field |
| apps/core/lib/prodigy/core/data/session.ex | New Session schema for persistent session records |
| apps/core/lib/prodigy/core/data/user.ex | Updated User schema to include concurrency_limit and sessions relationship |
| apps/server/lib/prodigy/server/context.ex | Renamed from Session to Context for ephemeral connection state |
| apps/server/lib/prodigy/server/service/logon.ex | Updated to use SessionManager for concurrency control |
| apps/server/lib/prodigy/server/service/logoff.ex | Updated to close sessions via SessionManager |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor sessions into a database table, support logon concurrency
Prodigy.Core.Data.Session, and the formerProdigy.Server.Sessionhas been renamedProdigy.Server.Context, which is used to store ephemeral state related to connection while that connection is active.