Skip to content

Conversation

@zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Feb 25, 2022

PR types

Function optimization

PR changes

OPs

Describe

[phi] move uniform_random to phi

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果cu这个中缀不是必要的,建议移除

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面优化下。

@zhiqiu zhiqiu force-pushed the uniform_random_to_phi branch from 6198878 to 6fd1ae3 Compare February 25, 2022 09:02
@zhiqiu zhiqiu closed this Feb 26, 2022
@zhiqiu zhiqiu reopened this Feb 26, 2022
chenwhql
chenwhql previously approved these changes Feb 26, 2022
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raindrops2sea
raindrops2sea previously approved these changes Feb 28, 2022
@zhiqiu zhiqiu dismissed stale reviews from raindrops2sea and chenwhql via 8d34517 February 28, 2022 05:05
@zhiqiu zhiqiu force-pushed the uniform_random_to_phi branch from 6fd1ae3 to 8d34517 Compare February 28, 2022 05:05
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit b346638 into PaddlePaddle:develop Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants