Skip to content

Conversation

@CtfGo
Copy link
Contributor

@CtfGo CtfGo commented Dec 8, 2021

PR types

Function optimization

PR changes

OPs

Describe

  1. add a subdirectory named cinn in paddle/fluid/operators directory and move releated files into it
  2. seperate CinnLaunchContext class from cinn_launch_op.h and put it in a new independent file named cinn_launch_context.h, so that it can be included by others clearly.

cinn_launch_op_test and cinn_launch_context_test passed on local test:
image
image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.


op_library(cinn_launch_op SRCS cinn_launch_op.cc cinn_launch_op.cu.cc DEPS cinn cinn_compiler cinn_launch_context)
cc_test(cinn_launch_op_test SRCS cinn_launch_op_test.cc DEPS cinn_compiler cinn_launch_op elementwise_add_op)
set_tests_properties(cinn_launch_op_test PROPERTIES ENVIRONMENT "OMP_NUM_THREADS=1;runtime_include_dir=${PADDLE_BINARY_DIR}/third_party/CINN/src/external_cinn/cinn/runtime/cuda")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add WITH_TESTING for CINN tests, like what I have done

Otherwise, if WITH_CINN=ON and WITH_TESTING=OFF, the compilation will fail.

Copy link
Contributor Author

@CtfGo CtfGo Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it

Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhhsplendid zhhsplendid merged commit 9cb637e into PaddlePaddle:develop Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants