[fleet_executor] Add interceptor ping pong test #37143
Conversation
|
Thanks for your contribution! |
There was a problem hiding this comment.
Should these new dependencies be also added to the BRPC_DEPS below?
There was a problem hiding this comment.
yes，or make test failed
There was a problem hiding this comment.
Hhh, my typo 😂
The interceptor id should be unique.
It's 'id' instead of 'is'. lmao.
There was a problem hiding this comment.
Why make this function public? I mean, under what circumstance will call this funct?
There was a problem hiding this comment.
Unnecessary public, maybe used by unittest, so set public.
There was a problem hiding this comment.
return void? If GetInterceptor is pubic for now, we can let users first call SetInterceptor to set, then call GetInterceptor to get the ptr?
There was a problem hiding this comment.
For convenient.
wangxicoding
force-pushed
the
add_interceptor_ping_pong_test
branch
from
7459074 to
cab13e6
Compare
FeixLiu
changed the title
| const InterceptorMessage& interceptor_message); | ||
|
|
||
| void Send(int64_t dst_id, std::unique_ptr<InterceptorMessage> msg); | ||
| void Send(int64_t dst_id, InterceptorMessage& msg); // NOLINT |
There was a problem hiding this comment.
不行，一开始msg只有message的内容，src_id和dst_id都是在Send里面填充的。
There was a problem hiding this comment.
或者单独搞一个消息体，和src_id，dst_id分开
There was a problem hiding this comment.
感觉是Send就是发送消息，这里还会修改Message稍微有点奇怪了
There was a problem hiding this comment.
是的，主要是Message里面带有src/dst信息。如果按照tcp/ip这样的协议，只需要传消息体，src/dst都是内部给封装好的
3 participants
PR types
Others
PR changes
Others
Describe
Add interceptor ping pong test.