Skip to content

Conversation

@phuctranfxvn
Copy link
Contributor

Requires OCA modules:

@phuctranfxvn phuctranfxvn mentioned this pull request Dec 27, 2020
36 tasks
@yvaucher
Copy link
Member

yvaucher commented Feb 4, 2021

⚠️ there are some on progress changes in #213

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the sale module addition to the dependencies needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it was a mistake, fixed, thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be deleted if not needed anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

@TDu
Copy link
Member

TDu commented May 17, 2021

Also in the commit related to the pre-commit hooks "account_invoice_export: black, isort, prettier" are all changes generated by the hooks ?
Because this one seems a cosmetic one
63eb325#diff-bcb6b814ad9e78b28e5c3b4d0958cb1c7e257d2ddebb48e7169fd3e6a929caffR24
And the previous maybe as well ?

@phuctranfxvn phuctranfxvn force-pushed the 14.0-mig-account_invoice_export branch from 571a1d6 to a27b0d3 Compare May 23, 2021 03:52
@TDu
Copy link
Member

TDu commented Jun 29, 2021

LG, there is just one more thing for me is this later commit 51b5aed#diff-8abaea68b746a4f70ee3b565778ece57657b089f5751cd9c41f66c8b5b18feb3 also need to be included. Thank you

@hailangvn hailangvn force-pushed the 14.0-mig-account_invoice_export branch from cde45af to fd40320 Compare July 3, 2021 01:52
@hailangvn
Copy link

@TDu, The commit has been included. Thanks for reviewing.

Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the migration

TDu and others added 6 commits September 13, 2021 21:35
Refactor to help integration by other module.
An example is on l10n_switzerland/ebill_paynet.
This change the visibility of the send eBill button on the invoice.
It is now only shown if the option is checked on the transmit method.
Also improve the configuration on the transmit method adding
information on the process.
@hailangvn hailangvn force-pushed the 14.0-mig-account_invoice_export branch from fd40320 to 213e668 Compare September 13, 2021 14:35
@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-299-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3316301 into OCA:14.0 Oct 15, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a4ea509. Thanks a lot for contributing to OCA. ❤️

@hailangvn hailangvn deleted the 14.0-mig-account_invoice_export branch October 15, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants