-
-
Notifications
You must be signed in to change notification settings - Fork 331
[MIG] account_invoice_export: Migration to 14.0 #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the sale module addition to the dependencies needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah it was a mistake, fixed, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be deleted if not needed anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks
|
Also in the commit related to the pre-commit hooks "account_invoice_export: black, isort, prettier" are all changes generated by the hooks ? |
571a1d6 to
a27b0d3
Compare
|
LG, there is just one more thing for me is this later commit 51b5aed#diff-8abaea68b746a4f70ee3b565778ece57657b089f5751cd9c41f66c8b5b18feb3 also need to be included. Thank you |
cde45af to
fd40320
Compare
|
@TDu, The commit has been included. Thanks for reviewing. |
TDu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the migration
Refactor to help integration by other module. An example is on l10n_switzerland/ebill_paynet.
This change the visibility of the send eBill button on the invoice. It is now only shown if the option is checked on the transmit method. Also improve the configuration on the transmit method adding information on the process.
fd40320 to
213e668
Compare
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at a4ea509. Thanks a lot for contributing to OCA. ❤️ |
Requires OCA modules:
account_invoice_transmit_methodwhich is being migrated in [14.0][MIG] account_invoice_transmit_method account-invoicing#823