[IMP] sale, (*_)loyalty: taxes on discounted amounts #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit: Taxes are applied to all reward lines regardless of discount mode or discount applicability . After this commit: Reward lines that reflect discounts on the order total will have a unit price matching the discount amount, and taxes will not be applied unless they are set manually for that reward or discount. This change applies when the discount mode is either per point or per order, and the discount applicability is on the order and also for fixed amount discounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of odoo@db12319
Before this commit:
Taxes are applied to all reward lines regardless of discount mode or discount applicability .
After this commit:
Reward lines that reflect discounts on the order total will have a unit price matching the discount amount, and taxes will not be applied unless they are set manually for that reward or discount. This change applies when the discount mode is either per point or per order, and the discount applicability is on the order and also for fixed amount discounts.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr