-
Notifications
You must be signed in to change notification settings - Fork 204
Add additional C48_ATM Rocoto Job CTests #4312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
TerrenceMcGuinness-NOAA
wants to merge
39
commits into
NOAA-EMC:develop
Choose a base branch
from
TerrenceMcGuinness-NOAA:add_C48_ATM_CTests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add additional C48_ATM Rocoto Job CTests #4312
TerrenceMcGuinness-NOAA
wants to merge
39
commits into
NOAA-EMC:develop
from
TerrenceMcGuinness-NOAA:add_C48_ATM_CTests
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystems module load for testing purposes
…he runtime rocotorun
The gfs_tracker job expects GRIB2 input files in products/atmos/grib2/0p25, but the test case was previously staging NetCDF history files to model/atmos/history. This mismatch would cause the data_check_gfs.sh script to fail.
This commit updates the test case to stage the correct gfs.t{cyc}z.pgrb2.0p25.f* files to the expected directory, ensuring the test environment matches the job's requirements.
The gfs_genesis job expects GRIB2 input files in products/atmos/grib2/0p25, but the test case was previously staging NetCDF history files to model/atmos/history.
Updated to stage gfs.t{cyc}z.pgrb2.0p25.f* files to the correct directory, matching the job's COM_ATMOS_GRIB_GRID_TMPL expectations.
…ged ROCOTO_TEST_PATH to ROCOTO_PATH
…update to role account with PR is ready)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Add C48_ATM CTests for Rocoto Job Validation
Summary
This PR extends the Global Workflow CTest framework with new atmospheric (C48_ATM) test cases for validating individual Rocoto jobs. The tests leverage Rocoto's new
--dryrunmode to extract job submission commands without spawning actual workflow daemons, enabling isolated job-level testing in CI/CD pipelines.New Test Cases
C48_ATM-gfs_stage_icJGFS_ATMOS_STAGE_ICC48_ATM-gfs_trackerJGFS_ATMOS_CYCLONE_TRACKERC48_ATM-gfs_genesisJGFS_ATMOS_CYCLONE_GENESISRocoto Dryrun Integration (separate PR in Rocoto)
The execute phase leverages Rocoto's
--dryrunmode to extract job submission commands:This approach:
Files Changed
New Test Case YAML Files
dev/ctests/cases/C48_ATM-gfs_stage_ic.yamldev/ctests/cases/C48_ATM-gfs_genesis.yamldev/ctests/cases/C48_ATM-gfs_tracker.yamlUpdated CMakeLists.txt
Added new
AddJJOBTest()calls for each C48_ATM test case:Updated Execute Script
Enhanced
execute.sh.into:ROCOTO_PATHfor dryrun-enabled Rocoto builds--dryrunmodePlatform Configuration Updates
dev/ci/platforms/config.heraROCOTO_PATH,STAGED_CTESTSsettingsdev/ci/platforms/config.herculesROCOTO_PATH,STAGED_CTESTSsettingsdev/ci/platforms/config.orionROCOTO_PATH,STAGED_CTESTSsettingsdev/ci/platforms/config.wcoss2ROCOTO_PATH,STAGED_CTESTSsettingsdev/ci/platforms/config.gaeac6ROCOTO_PATH,STAGED_CTESTSsettingsdev/ci/platforms/config.ursaROCOTO_PATH,STAGED_CTESTSsettingsGitLab CI Integration
.gitlab-ci.ymldev/ci/gitlab-ci-ctests.ymldev/ci/gitlab-ci-cases.ymlUsage
Local Execution
YAML Test Definition Format
Test cases use Jinja2 templating for flexible file path generation:
How has this been tested?
Dependencies
Rocoto Dryrun Feature
This PR depends on Rocoto's
--dryrunfeature which is currently in development:dry_run_no_daemonChecklist
--dryrunmodeAuthor: Terry McGuinness (@TerrenceMcGuinness-NOAA)
Target Branch:
developSource Branch:
add_C48_ATM_CTestsRelated PR: Rocoto Dryrun Feature