[WIP] Add parameters to include or exclude XcTestFile #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelslemos
force-pushed
the
add-include-exclude-xcfile
branch
from
de17646 to
0517835
Compare
Collaborator
chenxiao0228
left a comment
chenxiao0228
left a comment
There was a problem hiding this comment.
Can you elaborate your use case please?
Do you intend to skip a whole test suite? In that case you can just not pass that target to Bluepill.
| NSUInteger numBundles = [config.numSims integerValue]; | ||
| NSMutableArray *filteredXcTestFiles = [NSMutableArray new]; | ||
|
|
||
| for (BPXCTestFile *xcFile in xcTestFiles) { |
Collaborator
There was a problem hiding this comment.
Is it Github or the indentation is off?
| } | ||
|
|
||
| if (config.xcTestFileToSkip) { | ||
| for (BPXCTestFile *xcFile in [NSArray arrayWithArray:filteredXcTestFiles]) { |
Collaborator
There was a problem hiding this comment.
Can you merge these 2 for loops?
| @property (nonatomic, strong) NSNumber *failureTolerance; | ||
| @property (nonatomic) BOOL onlyRetryFailed; | ||
| @property (nonatomic, strong) NSArray *testCasesToSkip; | ||
| @property (nonatomic, strong) NSArray *xcTestFileToSkip; |
Collaborator
There was a problem hiding this comment.
xcTestFile -> testSuites please, closer to Xcode terminology
Author
|
Hey, I'm sorry this branch isn't ready for merging, I supposed this PR was open on my fork. |
miguelslemos
changed the title
Contributor
|
@miguelslemos Can you please rebase, resolve the conflicts and incorporate the code review comments? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, the purpose of this PR is to enable the ability to include or exclude the whole suite. In our case, we created a schema(AllTests) that builds all modules and then creates only a single
* .xctestrunfile that contains all the test suites. But we don't want to run all tests at once, because we do sharding by macOS nodes. So we built it once and share the artifact between the nodes, so we select few suites to run on each node