-
Notifications
You must be signed in to change notification settings - Fork 29
[WIP] Remote console access for VM's #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi @Fryguy, could you please share your insights or thoughts on this? |
| include Operations | ||
|
|
||
| include RemoteConsole | ||
| POWER_STATES = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have a newline after this:
| POWER_STATES = { | |
| POWER_STATES = { |
|
Checked commit Dhamo1107@074e65f with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/models/manageiq/providers/kubevirt/infra_manager/vm/remote_console.rb
|
|
This pull request is not mergeable. Please rebase and repush. |
|
This pull request is not mergeable. Please rebase and repush. |
|
Hi @agrare, I'm currently trying to understand the implementation in PR #269 (Remote console access for VMs), and I'm running into some issues while testing and completing it. Would you mind helping me understand a few parts of the code or guide me on how to properly finish and test the remote console integration for KubeVirt VMs? Your input would be really helpful. |
Enabling this functionality would allow users to interact directly with their KubeVirt VMs for troubleshooting, configuration and recovery.
@miq-bot add-label wip