ColBERT Upstream Updates #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `IndexUpdater` class for adding/removing new documents from an existing index. - `class_factory` wrapper for `HF_ColBERT` to initializing new types of models: - AutoModel - BERT - Deberta - Electra - Roberta - XLMRoberta - Example in README.
peteriz
approved these changes
Jun 20, 2023
Contributor
peteriz
left a comment
peteriz
left a comment
There was a problem hiding this comment.
LGTM.
any thoughts on updating the "updates" in the main readme?
plaid/colbert with newer models?
Contributor
Author
|
I can mention the new feature; support for HF models is in terms of classes compatibility, no new weights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexUpdaterclass for adding/removing new documents from an existing index.class_factorywrapper forHF_ColBERTto initializing new types of HF models: