-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENG-4034] chore: moves chef integration to ee #4796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR successfully migrates the Chef integration from the regular service layer to the Enterprise Edition (EE) layer. The changes are straightforward and well-organized:
Key Changes:
- Moved all Chef connection and secret sync code from
backend/src/services/tobackend/src/ee/services/ - Updated Chef router registrations from regular routers to EE routers
- Changed plan type from
RegulartoEnterprisein both app connection and secret sync maps - Added
enterprise: trueflag to Chef configuration in frontend and backend constants - Updated all import paths across the codebase to reference the new EE locations
- Minor cleanup: removed unnecessary type assertions in error messages
Architecture Impact:
The migration maintains all existing functionality while properly gating Chef integration behind the enterprise license check. All service registrations, router endpoints, authentication, and permission checks remain intact.
Confidence Score: 5/5
- This PR is safe to merge with minimal risk - it's a clean refactoring that moves code to EE without changing logic
- The PR is a straightforward code migration with no logical changes. All imports are properly updated, plan types are correctly changed to Enterprise, and the enterprise flags are consistently added across frontend and backend. The code movement preserves all existing functionality, authentication, permission checks, and error handling.
- No files require special attention - all changes are consistent and well-structured
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| backend/src/services/app-connection/app-connection-service.ts | 5/5 | Updates Chef service imports to EE namespace |
| backend/src/services/app-connection/app-connection-maps.ts | 5/5 | Changes Chef plan type from Regular to Enterprise |
| backend/src/services/secret-sync/secret-sync-maps.ts | 5/5 | Changes Chef sync plan type from Regular to Enterprise |
| frontend/src/helpers/appConnections.ts | 5/5 | Adds enterprise flag to Chef app connection in frontend |
| backend/src/ee/services/secret-sync/chef/chef-sync-constants.ts | 5/5 | Adds enterprise flag to Chef sync list option |
Sequence Diagram
sequenceDiagram
participant Router as App Connection Router
participant EERouter as EE Chef Router
participant Service as App Connection Service
participant EEService as EE Chef Service
participant Maps as Plan Type Maps
participant Frontend as Frontend Helpers
Note over Router,Frontend: Before: Chef in Regular Services
Router->>Service: Import from /services/app-connection/chef
Service->>Service: chef: Regular Plan Type
Frontend->>Frontend: Chef: no enterprise flag
Note over Router,Frontend: After: Chef in EE Services
Router->>EERouter: Import from /ee/.../chef-connection-router
EERouter->>EEService: Use EE Chef Service
Service->>EEService: Import from /ee/services/app-connections/chef
Maps->>Maps: Chef: Enterprise Plan Type
Frontend->>Frontend: Chef: enterprise: true
25 files reviewed, no comments
Description 📣
moves chef integration to ee
Type ✨
Tests 🛠️
Chef app-connection and secret sync should work fine
# Here's some code block to paste some code snippets