fix: restore path based parsing in 4.0 #566
Conversation
This fixes issue 564 also safely wraps strings for parsing [564]
nnungest
force-pushed
the
fix/parse-parent-dirs
branch
from
8847853 to
2c0c026
Compare
|
Im not sure if the last 2 checks apply to this PR but im happy to update things if needed. In this case I don't think the test should be touched as this should keep the same functionality as before intact. |
|
Thanks! this fixed my issue. Looks like @IlanCosman hasn't been active much recently, but hopefully this makes its way in |
* remove _tide_cache_variables * apply IlanCosman#566 * update makefile * fix * fix color * fix indent
|
Thanks! |
credit to @scaryrawr where credit is due.
|
Thank you. Hope to merge soon！ |
|
It seems the owner is not very active anymore. Is anyone willing to start a fork? |
ive since started using starship instead. |
|
For what it's worth, I've started going through the various PRs here on the fork I created and seeing about getting them merged in. |
|
@plttn Thank you! I started using that fork. I setup a new machine and was going crazy over missing icons. I couldn't understand where the failure was coming from until I realized the new machine is on fish 4 and the old machine was on fish 3 and I was hitting that parent dirs issue |
|
@nnungest Thank you very much for the fix. @everyone Apologies for the long absence, the reality is just that my priorities changed and I didn't want to work on Tide. I realize that completely dropping off the map was rather uncool of me as a maintainer. My plan going forward is to come back to Tide and give it at least a bit of my time each week to keep it in a healthy and good state. @plttn I really appreciate you carrying the torch forward on improving Tide. I'd be happy to review any changes from your branch and get them merged into the main project so that more people can enjoy your work. That said I would completely understand if you feel a bit negatively towards me / the main Tide project. |
|
@IlanCosman I completely understand and don't hold it against you, stuff happens! Feel free to take a look at my fork and bring in those changes, additionally I'd be open to collaborating with you on an ongoing basis so that you can not worry about Tide getting abandoned. |
|
hey @IlanCosman I understand your feelings as I've been in a similar position as you with an open source project I started. What I did once I realized I didn't want to work on it is adding someone that was willing as a maintainer of the repo to move things forward. Perhaps that would help you and still let the project go on :) I wish you all the best :) |
* fix: ensure dirs arent empty strings This fixes issue 564 also safely wraps strings for parsing [564] * fix: scope parts variable to function * chore: fix formatting * fix: remove hacky length test, clean up join credit to @scaryrawr where credit is due.
11 participants
This fixes issue 564, where empty directories are returned after upgrading to 4.0.0. This also safely wraps paths.
Description
Restore path based parsing for a variety of _tide_item functions.
Motivation and Context
When a user changes directory into a one that contains, lets say package.json, tide normally picks up the version and prints it on the status line. This stopped working when fish moved to 4.0.0. This restores the previous behavior by checking for directories that are invalid (zero length) and safely wrapping the directories with quotes.
Closes #564
Screenshots (if appropriate)
How Has This Been Tested
I ran this against the make commands list in contributing.
Checklist