Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Oct 28, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copilot AI review requested due to automatic review settings October 28, 2025 12:00
@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Oct 28, 2025
@cho-m cho-m mentioned this pull request Oct 28, 2025
65 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GammaRay formula to conditionally exclude the qtwebengine dependency on arm64 Linux systems. The change addresses a bottling issue where qtwebengine is not yet available for arm64 Linux architecture.

Key Changes:

  • Refactored qtwebengine dependency conditions to be architecture-specific on Linux
  • Added a TODO comment indicating the temporary nature of this exclusion

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Oct 28, 2025
@chenrui333 chenrui333 added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit 125beb9 Oct 28, 2025
33 checks passed
@chenrui333 chenrui333 deleted the gammaray-no-qtwebengine-arm64-linux branch October 28, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-bottles Merge without publishing bottles linux-arm-bottling ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants