Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Oct 28, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

At least until we get a self-hosted runner.

Copilot AI review requested due to automatic review settings October 28, 2025 11:55
@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Oct 28, 2025
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Oct 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR excludes the qtwebengine and qtwebview dependencies for arm64 Linux builds of PySide, addressing a bottling limitation where these Qt components are not yet available on arm64 Linux architecture.

Key changes:

  • Restructured macOS-specific dependencies to use on_sonoma :or_newer instead of the previous on_system approach
  • Added architecture-specific dependency handling for Linux, limiting qtwebengine and qtwebview to Intel platforms only
  • Updated the test to conditionally import WebEngineCore module based on architecture

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 28, 2025
Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>
@cho-m cho-m force-pushed the pyside-no-qtwebengine-arm64-linux branch from b59005d to d1855b8 Compare October 28, 2025 11:56
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 28, 2025
@cho-m cho-m mentioned this pull request Oct 28, 2025
65 tasks
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Oct 28, 2025
@chenrui333 chenrui333 added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit a9c1be8 Oct 28, 2025
34 checks passed
@chenrui333 chenrui333 deleted the pyside-no-qtwebengine-arm64-linux branch October 28, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-bottles Merge without publishing bottles linux-arm-bottling python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants