Skip to content

feature: fixed header add class on vertical scroll #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangshuwei merged 3 commits into from
Feb 9, 2023
Merged

feature: fixed header add class on vertical scroll #544

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1207090
feature: fixed header add class on vertical scroll
looeyf Feb 9, 2023
5051ebd
refactor: create consts only if needed
looeyf Feb 9, 2023
61c4d3d
fix: setScrolling function indentation
looeyf Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/ve-table/src/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,8 @@ export default {
isLeftScrolling: false,
// is scrolling right
isRightScrolling: false,
// is scrolling vertically
isVerticalScrolling: false,
// has horizontal scroll bar
hasXScrollBar: false,
// has vertical scroll bar
Expand Down Expand Up @@ -588,6 +590,7 @@ export default {
isVirtualScroll,
isLeftScrolling,
isRightScrolling,
isVerticalScrolling,
isCellEditing,
isAutofillStarting,
enableCellSelection,
Expand All @@ -598,6 +601,7 @@ export default {
[clsName("virtual-scroll")]: isVirtualScroll,
[clsName("container-left-scrolling")]: isLeftScrolling,
[clsName("container-right-scrolling")]: isRightScrolling,
[clsName("container-vertical-scrolling")]: isVerticalScrolling,
[clsName("is-cell-editing")]: isCellEditing,
[clsName("autofilling")]: isAutofillStarting,
// 如果开启单元格选择，则关闭 user-select
Expand Down Expand Up @@ -2071,6 +2075,11 @@ export default {
this.isLeftScrolling = scrollLeft > 0;
this.isRightScrolling = scrollWidth - clientWidth > scrollLeft;
}

if (this.fixedHeader) {
const { scrollTop } = tableContainerRef;
this.isVerticalScrolling = scrollTop > 0;
}
},

// set scroll bar status
Expand Down