NetUtil.dataToChunks not setting ParsedChunkData fields

[t81lal]

In NetUtil.dataToChunks it doesn't look like the ParsedChunkData is getting it's fields set properly. This may just be me but all of the blocks in ServerChunkDataPacket and ServerMultiChunkDataPacket are 0 which is causing me a real brainache. It'd be awesome if you could check this out, thanks!

[t81lal]

Right, I just did some testing and I think this is a bug. By adding in chunks[ind].setBlocks(blocks); into NetUtil.dataToChunks, the block data is not empty, same with the other fields.

[t81lal]

I added setters in Chunk for my own purposes.
if (pass == 1) {
chunks[ind] = new Chunk(sky || data.hasSkyLight(), (data.getExtendedMask() & 1 << ind) != 0);
ByteArray3d blocks = chunks[ind].getBlocks();
System.arraycopy(data.getData(), pos, blocks.getData(), 0, blocks.getData().length);
chunks[ind].setBlocks(blocks);
pos += blocks.getData().length;
}
That's what I edited in dataToChunks

[t81lal]

But the blocks field doesn't contain any data and is never set, so how would I get block data from the ServerMultiChunkDataPacket?

[t81lal]

But inbetween those calls there is System.arraycopy(data.getData(), pos, blocks.getData(), 0, blocks.getData().length); which copies the correct block data into the blocks field.

[t81lal]

Yeah all of the blocks are set to 0 for me even though I am in a world which isn't just air :/

WOOPS just checked, I had edited the packet class itself and it broke something. Sorry >.<