Skip to content

Remove unnecessary LM object removal in evaluator #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luodian merged 3 commits into from
Sep 6, 2024
Merged

Remove unnecessary LM object removal in evaluator #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbcb33d
chore: Remove composite task in formal MMMU-Pro evaluation
Luodian Sep 6, 2024
94483d0
Remove unnecessary LM object removal in evaluator
Luodian Sep 6, 2024
020d88a
Merge branch 'main' into patch/revert-deletion
Luodian Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lmms_eval/evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,9 +610,6 @@ def evaluate(
if hasattr(lm, "accelerator"):
lm.accelerator.wait_for_everyone()

if not isinstance(lm, lm_eval.api.model.LM):
del lm

return results_dict


Expand Down
1 change: 1 addition & 0 deletions lmms_eval/tasks/mmmu_pro/mmmu_pro.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
group: mmmu_pro
task:
- mmmu_pro_vision
# - mmmu_pro_composite # removing composite task in formal MMMU-Pro evaluation
- mmmu_pro_original