-
-
Notifications
You must be signed in to change notification settings - Fork 693
feat(email): include notification level in email subject line #5503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
nscuro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you accidentally modified a Dependabot commit here, can you please resolve that? Otherwise LGTM.
Adds the NotificationRule's level (e.g. [WARNING], [ERROR]) to the subject of outgoing SMTP emails. Improves clarity and urgency of notifications received by users. Uses ctx.ruleLevel() for formatting. Signed-off-by: ch8matt <[email protected]>
|
"INFORMATIONAL" can be interpreted as "no action required" by organizations. Please consider allowing this feature to be disabled. |
Signed-off-by: ch8matt <[email protected]>
|
A new toggle, disabled by default, has been added to enable the feature. |
Adds the NotificationRule's level (e.g. [WARNING], [ERROR]) to the subject of outgoing SMTP emails. Improves clarity and urgency of notifications received by users. Uses ctx.ruleLevel() for formatting.
Description
Adds the notification level (e.g., [WARNING], [ERROR], [INFORMATIONAL]) to the subject line of outgoing SMTP notification emails. This improves visibility and urgency of alerts directly from the subject without needing to open the email.
Addressed Issue
Additional Details
Checklist