Make Ansible Tasks in postfix rules idempotent #13930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new optional parameter `register` of `ansible_set_config_file` will allow callers to register a variable holding result of the lineinfile task and use this registered variable in other tasks to check if lineinfile module changed the target file or if the target file is alrady configured OK.
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ggbecker
approved these changes
Sep 29, 2025
Member
ggbecker
left a comment
ggbecker
left a comment
There was a problem hiding this comment.
I have run ansible playbooks tests and automatus with the same set of rules reported by CTF in the Automatus gating tests using a RHEL9 system and everything worked as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR will make Ansible remediations in the following rules idempotent:
Specifically, the Ansible Task that executes the
newaliasesshell command will now be run only if the configuration file has been changed by the Ansible Task above.As a part of the solution, we will add new optional parameter
registerto theansible_set_config_fileJinja macro. It will allow callers to register a variable holding result of the lineinfile Ansible Task and use this registered variable in other Ansible Tasks to check if lineinfile module changed the target file or if the target file is already configured OK.Rationale:
Resolves: https://issues.redhat.com/browse/OPENSCAP-6245
Review Hints:
./build_product --playbook-per-rule rhel9ansible-playbook -u root -i YOUR_IP, build/rhel9/playbooks/stig/postfix_client_configure_mail_alias.ymlat least twice and compare the output of the first run with the second run and so on, verify that the second and next runs don't change anything and that the output contains only "ok" or "skipping"--remediate-using ansible