Fix tests for rule grub2_pti_argument #13733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
requested review from
Mab879,
matusmarhefka and
vojtapolasek
as code owners
Some test scenarios for rule `grub2_pti_argument` are failing. The reason is that `pti` is a substring of `options`. This is caused by recent change that make the equal sign `=` optional. This change has been introduced by ComplianceAsCode#13726. After this change some regular expressions for the `pti` argument started to match `options`. We will prevent that by using word bounds marks (`\<` and `\>`) in regular expressions. Also, as a part of this commit we will fix coding style. Fixes: ComplianceAsCode#13732
Collaborator
Author
|
I have rebased this PR on the top of the latest upstream master branch. |
Collaborator
|
/packit retest-failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test scenarios for rule
grub2_pti_argumentare failing. The reason is thatptiis a substring ofoptions. This is caused by recent change that make the equal sign=optional. This change has been introduced by#13726. After this change some regular expressions for the
ptiargument started to matchoptions. We will prevent that by using word bounds marks (\<and\>) in regular expressions. Also, as a part of this commit we will fix coding style.Rationale
Fixes: #13732
Review Hints:
Run automatus for grub2_pti_argument, grub2_audit_argument and grub2_nousb_argument