Support banner with single quote #13713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of `dod_short` selector in variable login_banner_text contains single quotes but the bash remediation uses single quotes for the variable which conflicts with the single quote inside the value and leads to incomplete bash remediation. To change single quotes to double quotes for the variable, we need to use a different construction than using the bash_instantiate_variables Jinja macro. The commit also adds a test scenario that covers this situation. Resolves: https://issues.redhat.com/browse/OPENSCAP-5403
vojtapolasek
approved these changes
Jul 18, 2025
Collaborator
vojtapolasek
left a comment
vojtapolasek
left a comment
There was a problem hiding this comment.
I verified the fix with local Automatus tests.
vojtapolasek
merged commit d8a5162
into
ComplianceAsCode:master
123 of 127 checks passed
jan-cerny
added a commit
to jan-cerny/scap-security-guide
that referenced
this pull request
Jul 25, 2025
Similar to: ComplianceAsCode#13713 Fixes: ComplianceAsCode#13737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
dod_shortselector in variable login_banner_text contains single quotes but the bash remediation uses single quotes for the variable which conflicts with the single quote inside the value and leads to incomplete bash remediation. To change single quotes to double quotes for the variable, we need to use a different construction than using the bash_instantiate_variables Jinja macro.The commit also adds a test scenario that covers this situation.
Resolves: https://issues.redhat.com/browse/OPENSCAP-5403