Add the ability built more than one product with SRG XLSX Option #13693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 3d737a3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.7% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Jul 15, 2025
Collaborator
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
I have followed the instructions in review hints and it has built spreadsheets for both RHEL 9 and RHEL 10 in the single run successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow building more than one product if using
SSG_SRG_XLSX_EXPORT=ONRationale:
Make the build system easier to use.
Review Hints:
Run the following on master and this branch. Observe on this branch the products built.
export ADDITIONAL_CMAKE_OPTIONS="-DSSG_SRG_XLSX_EXPORT=ON"$ ./build_product rhel8 rhel9 rhel10