Skip to content

Conversation

@mrkanon
Copy link
Contributor

@mrkanon mrkanon commented May 29, 2025

Description:

  • Update var_password_pam_unix_rounds for OL9 stig control
  • Add OL9 to accounts_password_pam_unix_rounds_* tests

Rationale:

Align OL9 STIG profile with DISA STIG OL9 V1R1

@openshift-ci
Copy link

openshift-ci bot commented May 29, 2025

Hi @mrkanon. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label May 29, 2025
@mrkanon mrkanon changed the title Sufficient rounds Update var_password_pam_unix_rounds for OL9 stig control May 29, 2025
@Mab879 Mab879 self-assigned this May 29, 2025
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Xeicker please take a look as well.

@Mab879 Mab879 added this to the 0.1.78 milestone May 29, 2025
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 10a6029 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.8% (0.0% change).

View more on Code Climate.

@Xeicker Xeicker added Oracle Linux Oracle Linux product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates. labels May 29, 2025
@Xeicker
Copy link
Contributor

Xeicker commented May 29, 2025

changes LGTM

UBI9 test fails due to not tests available for it
UBUNTU fails because the rule is not present in this product's profiles

@Xeicker Xeicker merged commit 32da483 into ComplianceAsCode:master May 29, 2025
119 of 123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Used by openshift-ci bot. Oracle Linux Oracle Linux product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants