Skip to content

Add rule file_groupowner_journalctl #11841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dodys merged 1 commit into from
May 7, 2024
Merged

Add rule file_groupowner_journalctl #11841

dodys merged 1 commit into from
May 7, 2024

Conversation

@mpurg
Copy link
Contributor

@mpurg mpurg commented Apr 17, 2024

Description:

  • New rule for auditing groupownership of journalctl command
  • Satisfies STIG requirement UBTU-22-232105
  • Based on file_owner_system_journal

@mpurg mpurg requested a review from a team as a code owner April 17, 2024 08:19
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 17, 2024
@openshift-ci
Copy link

openshift-ci bot commented Apr 17, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Apr 17, 2024

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2204 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11841
This image was built from commit: efdc9a6

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11841

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11841 make deploy-local

@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. New Rule Issues or pull requests related to new Rules. and removed needs-ok-to-test Used by openshift-ci bot. labels Apr 17, 2024
@dodys
Copy link
Contributor

dodys commented Apr 17, 2024

/packit retest-failed

@dodys dodys self-assigned this Apr 17, 2024
@dodys dodys requested review from a team April 17, 2024 11:03
@dodys
Copy link
Contributor

dodys commented Apr 17, 2024

Added red-hatters and suse maintainers as this new rule might be relevant for them
@marcusburghardt @Mab879 @teacup-on-rockingchair

@marcusburghardt
Copy link
Member

marcusburghardt commented Apr 18, 2024

Please, make sure the new rule is mapped to a component in https://github.com/ComplianceAsCode/content/tree/master/components

@mpurg mpurg force-pushed the ubuntu_2204_stig_232105 branch 2 times, most recently from 6ef1481 to 29a11de Compare April 18, 2024 09:07
@mpurg
Copy link
Contributor Author

mpurg commented Apr 18, 2024

@marcusburghardt , fixed!

teacup-on-rockingchair
teacup-on-rockingchair approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mpurg mpurg force-pushed the ubuntu_2204_stig_232105 branch from 29a11de to d8e3bed Compare April 29, 2024 08:00
@dodys
Copy link
Contributor

dodys commented Apr 30, 2024

/packit build

@marcusburghardt
Copy link
Member

marcusburghardt commented May 6, 2024

@mpurg , currently we can't re-trigger the stalled testing-farm tests in CI, unfortunately. Could you rebase or simply amend the last commit to re-trigger them, please?

@mpurg
Add rule file_groupowner_journalctl
efdc9a6 
- New rule for auditing groupownership of journalctl command
- Satisfies STIG requirement UBTU-22-232105
- Based on file_owner_system_journal
@mpurg mpurg force-pushed the ubuntu_2204_stig_232105 branch from d8e3bed to efdc9a6 Compare May 6, 2024 14:07
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented May 6, 2024

Code Climate has analyzed commit efdc9a6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@dodys
Copy link
Contributor

dodys commented May 7, 2024

/packit test

dodys
dodys approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 5a5ca71 into ComplianceAsCode:master May 7, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcusburghardt marcusburghardt marcusburghardt left review comments

@teacup-on-rockingchair teacup-on-rockingchair teacup-on-rockingchair approved these changes

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels

New Rule Issues or pull requests related to new Rules. ok-to-test Used by openshift-ci bot. STIG STIG Benchmark related. Ubuntu Ubuntu product related.

Projects

None yet

Milestone

0.1.74

Development

Successfully merging this pull request may close these issues.

5 participants

@mpurg @dodys @marcusburghardt @teacup-on-rockingchair @Mab879