Skip to content

Add rules for /etc/shells #11467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcusburghardt merged 4 commits into from
Jan 24, 2024
Merged

Add rules for /etc/shells #11467

marcusburghardt merged 4 commits into from
Jan 24, 2024

Conversation

@Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 23, 2024

Description:

  • Add rules
    • file_permissions_etc_shells
    • file_groupowner_etc_shells
    • file_owner_etc_shells
  • Add above rules to RHEL 8 CIS 6.1.10

Rationale:

RHEL 8 CIS

@Mab879 Mab879 added New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 23, 2024
@Mab879 Mab879 added this to the 0.1.72 milestone Jan 23, 2024
@Mab879 Mab879 requested a review from a team as a code owner January 23, 2024 22:14
@github-actions
Copy link

github-actions bot commented Jan 23, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jan 23, 2024

Code Climate has analyzed commit 204b90f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Jan 24, 2024
marcusburghardt
marcusburghardt approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I triggered some failed CI tests again but the new rules are good.

@marcusburghardt
Copy link
Member

marcusburghardt commented Jan 24, 2024

I checked the failed Automatus tests and they are failing during the clean-up, after the rule tests.
There are no issues testing the rules, so the tests can be safely waived in this particular case.

We are investigating the issue with automatus task "Delete datastream artifact".

@marcusburghardt marcusburghardt merged commit f03f6c7 into ComplianceAsCode:master Jan 24, 2024
@marcusburghardt marcusburghardt added the RHEL8 Red Hat Enterprise Linux 8 product related. label Jan 24, 2024
@Mab879 Mab879 deleted the add_etc_shell_rules branch January 24, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels

CIS CIS Benchmark related. New Rule Issues or pull requests related to new Rules. RHEL8 Red Hat Enterprise Linux 8 product related. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Milestone

0.1.72

Development

Successfully merging this pull request may close these issues.

2 participants

@Mab879 @marcusburghardt