Skip to content

Progress bar added to learn and populate functions #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Rahgooy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Progress bar added to learn and populate functions #485

Rahgooy wants to merge 1 commit into from

Conversation

@Rahgooy
Copy link
Collaborator

@Rahgooy Rahgooy commented Aug 18, 2017

targets issue #452

@danyaljj
Copy link
Member

danyaljj commented Aug 18, 2017

Thanks Taher!
Do you have an screenshot?
Also, did you test it for JointTraining?

@Rahgooy
Copy link
Collaborator Author

Rahgooy commented Aug 18, 2017

Sure,
image

and about your second question, no I didn't test it with joint train

@danyaljj
Copy link
Member

danyaljj commented Aug 18, 2017

Screenshot: Looks good. Thanks.

@Rahgooy Rahgooy requested a review from kordjamshidi August 24, 2017 18:11
kordjamshidi
kordjamshidi reviewed Aug 29, 2017
View reviewed changes
Copy link
Member

@kordjamshidi kordjamshidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too.

@kordjamshidi
Copy link
Member

kordjamshidi commented Aug 29, 2017 •
edited
Loading

regarding the jointraining comment, I don't think this is working for that since the training goes through a different object JointTrainSparseNetwork, but tis progress bar is placed only in learnable. @Rahgooy @danyaljj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kordjamshidi kordjamshidi kordjamshidi left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rahgooy @danyaljj @kordjamshidi