Skip to content

Conversation

@cx-andre-pereira
Copy link
Contributor

Reason for Proposed Changes

Proposed Changes

  • First i implemented a check for the resource.Properties.SSESpecification.SSEEnabled to ensure it is not set to false.
  • Through the documentation for the AWS::DAX::Cluster and SSESpecification i realised that both the SSESpecification and SSEEnabled are optional fields; given this i added case handling for missing either one of these fields.
  • For the tests, positive1/2 and positive5/6 represent the most simple SSEEnabled set to false scenario, in JSON and YAML formats for false/"false" values.
  • The rest of the positive tests are missing either the SSESpecification or SSEEnabled field and flag accordingly.

I submit this contribution under the Apache-2.0 license.

@cx-andre-pereira cx-andre-pereira requested a review from a team as a code owner July 29, 2025 09:37
@github-actions github-actions bot added feature New feature query New query feature cloudformation CloudFormation query terraform Terraform query aws PR related with AWS Cloud labels Jul 29, 2025
@github-actions
Copy link
Contributor

kics-logo

KICS version: v2.1.11

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

Copy link
Contributor

@cx-eduardo-semanas cx-eduardo-semanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gitguardian
Copy link

gitguardian bot commented Aug 14, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
4266022 Triggered Generic Password 02c7fa8 assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/negative7.yaml View secret
9419039 Triggered Username Password 02c7fa8 assets/queries/cloudFormation/aws/amplify_app_basic_auth_config_password_exposed/test/positive6.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@cx-artur-ribeiro cx-artur-ribeiro merged commit 141311a into master Aug 14, 2025
28 checks passed
@cx-artur-ribeiro cx-artur-ribeiro deleted the AST-40774--FN_DAX_Cluster_Not_Encrypted-cloudformation branch August 14, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws PR related with AWS Cloud cloudformation CloudFormation query feature New feature query New query feature terraform Terraform query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants