fix(query): fn for Trusted Microsoft Services Not Enabled - ARM

[cx-andre-pereira]

Reason for Proposed Changes

• Currently this query checks if Microsoft.Storage/storageAccounts resources by assuring the field properties.networkAcls.defaultAction is not set as "Allow" , and that properties.networkAcls.bypass does not contain "AzureServices" as either of those scenarios would enable "Trusted Microsoft Services".
• The query , however, does not account for the possibility of the resource missing the properties,properties.networkAcls or properties.networkAcls.defaultAction/bypass fields entirely.

Proposed Changes

• I have implemented a "path_check" function that confirms the path to the defaultAction and/or bypass nested fields exists. Moreover the lack of a complete path will properly flag the Microsoft Services as Not Enabled and point to the "deepest" field along the path route(either"","properties" or "properties.networkAcls") on the "searchKey".

Note: I could not find explicit documentation stating the effects of missing "networkAcls" or other fields, but it seems to result in unexpected behavior depending on file/system context which, i feel, still makes this flag pertinent.

I submit this contribution under the Apache-2.0 license.

[cx-artur-ribeiro]

Hey André,
Please take a look at my comments and I'll review again after.

If you need any help, please fell free to contact 😄

[cx-artur-ribeiro]

Hey André, besides my comment, the only other strange thing is this result:
{
"queryName": "Trusted Microsoft Services Not Enabled",
"severity": "MEDIUM",
"line": 19,
"fileName": "positive6.json"
},

Seems like we are pointing to "types" instead of the resource but I can't understand why. It seems to be related to the .json file somehow.

Other than that, everything seems good.

[cx-artur-ribeiro]

LGTM

[gitguardian]

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
19562607	Triggered	Generic Password	ffdb371	assets/queries/common/passwords_and_secrets/test/positive53.json	View secret
4266022	Triggered	Generic Password	c9ec1e3	assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/negative7.yaml	View secret
9419039	Triggered	Username Password	c9ec1e3	assets/queries/cloudFormation/aws/amplify_branch_basic_auth_config_password_exposed/test/positive5.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}