Skip to content

feat(analyzer): add a blacklist to the Analyzer to exclude FHIR files #7470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cx-artur-ribeiro merged 17 commits into from
May 26, 2025
Merged

feat(analyzer): add a blacklist to the Analyzer to exclude FHIR files #7470

cx-artur-ribeiro merged 17 commits into from
May 26, 2025

Conversation

@cx-artur-ribeiro
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro commented May 19, 2025 •
edited
Loading

Reason for Proposed Changes

  • FHIR files were incorrectly being detected as ARM files, which caused the parser to attempt to resolve files that do not belong to any supported platform;.

Proposed Changes

  • Add a blacklist to the Analyzer to exclude FHIR files;
  • Fix kics github action "go-e2e" in order to export multiple files from the e2e report output;

I submit this contribution under the Apache-2.0 license.

@cx-artur-ribeiro cx-artur-ribeiro self-assigned this May 19, 2025
@cx-artur-ribeiro cx-artur-ribeiro added bug Something isn't working feature New feature labels May 19, 2025
@github-actions github-actions bot added arm Azure Resource Manager query and removed bug Something isn't working labels May 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

kics-logo

KICS version: v2.1.7

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-artur-ribeiro cx-artur-ribeiro changed the title feat(analyzer): blacklist FHIR files and add ignoredFiles to report output feat(analyzer): add a blacklist to the Analyzer to exclude FHIR files May 19, 2025
@cx-artur-ribeiro cx-artur-ribeiro marked this pull request as ready for review May 20, 2025 11:29
@cx-artur-ribeiro cx-artur-ribeiro requested a review from a team as a code owner May 20, 2025 11:29
cx-rui-araujo
cx-rui-araujo approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@cx-rui-araujo cx-rui-araujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-artur-ribeiro cx-artur-ribeiro merged commit 0694206 into master May 26, 2025
25 checks passed
@cx-artur-ribeiro cx-artur-ribeiro deleted the AST-73985 branch May 26, 2025 15:17
JonasCordsen pushed a commit to JonasCordsen/kics that referenced this pull request Jun 11, 2025
@cx-artur-ribeiro
feat(analyzer): add a blacklist to the Analyzer to exclude FHIR files (…
fd3d819 
…Checkmarx#7470)

* add new Ignored Files parameter to scan results verbose and remove FHIR documents from being parsed

* rename getTotalFiles to GetTotalFiles

* add a new counter IgnoredFiles

* fix gocritic lint issue

* refactor Counters print with correct order

* revert addition of ignored files to report output

* revert addition of ignored files field

* add e2e to test fhir files skip from KICS scan

* remove unnecessary check for fhir as a return type

* add unit test to analyzer_test.go for fhir file

* add fhir to all exclude files

* add fhir file to TestProvider_getExcludePaths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-rui-araujo cx-rui-araujo cx-rui-araujo approved these changes

Assignees

@cx-artur-ribeiro cx-artur-ribeiro

Labels

arm Azure Resource Manager query feature New feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cx-artur-ribeiro @cx-rui-araujo