feat(resolver): kubernetes circular dependency is causing resource exhaustion #7421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
KICS version: v2.1.7
|
cx-artur-ribeiro
changed the title
…owing once resolutions
… on TestResolver_Resolve_Without_ResolveReferences (5/8)
cx-miguel-silva
commented
May 12, 2025
JonasCordsen
pushed a commit
to JonasCordsen/kics
that referenced
this pull request
Jun 11, 2025
…haustion (Checkmarx#7421) * stage * draft check for circular references * comment failing test and solve lint * remove stashed currentResolutionPath from previous resolved files allowing once resolutions * remove wrong comments and add no lint statement * fix TestResolver_Resolve_Ansible_Vars unit test * fix 2 tests on TestResolver_Resolve_With_ResolveReferences and 1 test on TestResolver_Resolve_Without_ResolveReferences (5/8) * fix all unit tests * add lint ignore * remove lint ignore * add Test_checkCircularReference tests * remove deprecated function ioutil.ReadFile * remove unnecessary comments * first json temporary solution and handleMap RefMedatada refactor * add resolution for json files * solve unit tests although they seem to be wrongly implementedgi * refactor code and solve unit tests * fix lint issues and e2e test * add e2e that compares the payload between json and yaml files * fix mixing want status and lint lll * add missing payloads * refactor payload, folder name and fix e2e * change comments on e2e * refactor names to be according to other files naming conventions * remove duplicated unit test * fix typo on e2e comment * remove resolved file at least once solution * update e2e 099 payload with new implemented code * update file and id from e2e payload * remove currentResolutionPath from TestResolver * revert addition of \n to test error output * add Clear mechanism on ResolvedFilesCache to force re-resolution of all files * add nolint gocyclo * check if the file can or cannot be cached during the for cycle --------- Co-authored-by: ArturRibeiro-CX <[email protected]> Co-authored-by: ArturRibeiro-CX <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
Proposed Changes
I submit this contribution under the Apache-2.0 license.