-
Notifications
You must be signed in to change notification settings - Fork 328
Update translations #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translations #799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments (2)
- i18n/de/docusaurus-plugin-content-docs/current/adguard-for-windows/solving-problems/tdi-driver-and-Chrome-142.md (12-12) This file is supposed to be a German translation, but most of the content remains in English. Only the intro section and the conclusion ('Fertig!') are translated to German. For consistency, the entire document should be translated to German.
- i18n/ru/docusaurus-plugin-content-docs/current/adguard-for-windows/solving-problems/tdi-driver-and-Chrome-142.md (93-93) There's a numbering issue in the manual instructions section. After step 5, the numbering restarts at 1 instead of continuing with 6, which could confuse readers following the instructions sequentially.
💡 To request another review, post a new comment with "/windsurf-review".
| @@ -0,0 +1,129 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be a partially translated document. While it's in the Russian localization folder (i18n/ru/), most of the content remains in English with only the info box at the top and the word "Готово!" (Done!) at the end in Russian. For consistency, the entire document should be translated to Russian.
| Este artículo trata sobre AdGuard para Windows, un bloqueador de anuncios multifuncional que protege tu dispositivo a nivel de sistema. To see how it works, [download the AdGuard app](https://agrd.io/download-kb-adblock). | ||
|
|
||
| ::: | ||
|
|
||
| Some AdGuard for Windows users may notice that [the app stops filtering traffic in Chromium-based browsers](https://github.com/AdguardTeam/AdguardForWindows/issues/5771). Starting from Google Chrome 142+, browser traffic simply does not appear at the TDI driver level, preventing AdGuard from inspecting or filtering it. | ||
|
|
||
| This behavior is not a bug in AdGuard, but a result of recent architectural and security changes in modern browsers. | ||
|
|
||
| ## Why this happens | ||
|
|
||
| Chromium-based browsers (Chrome, Edge, Brave, Vivaldi, etc.) have been strengthening their security architecture. One significant change is moving sensitive internal processes into the [Windows AppContainer sandbox](https://learn.microsoft.com/en-us/windows/win32/secauthz/appcontainer-isolation), including the Network Service, which handles all browser traffic. | ||
|
|
||
| ### What changed in Chrome 142 | ||
|
|
||
| Starting from Chrome 142, the Network Service process is now launched inside AppContainer by default. | ||
|
|
||
| When this happens, applications running in an AppContainer do not use the legacy TDI networking interface; instead, their traffic is routed through the more modern WSK (Winsock Kernel) stack. As a result, the TDI driver cannot see, intercept, or process connections that go through WSK, and all browser traffic becomes invisible to the TDI driver used by AdGuard. | ||
|
|
||
| This behavior is controlled entirely by Chrome’s sandboxing policies and internal experiments (field trials), not by user settings. | ||
|
|
||
| ## Why this affects AdGuard | ||
|
|
||
| The TDI driver is an outdated Windows technology that has been deprecated and unsupported by Microsoft for many years. It is not compatible with modern isolation and sandboxing models used by browsers. | ||
|
|
||
| Because of this, TDI-based traffic visibility becomes increasingly unstable. In some browsers, it has already disappeared completely, and it will eventually stop working altogether. | ||
|
|
||
| AdGuard already treats the TDI driver as deprecated, and its complete removal is planned as the product evolves. | ||
|
|
||
| ## Temporary solution | ||
|
|
||
| Certain Windows registry changes can force the browser to stop using AppContainer, causing its processes to run in a non-sandboxed mode again. Network Service stops using the WSK stack and falls back to a network path that the TDI driver can see. AdGuard then regains the ability to filter browser traffic. | ||
|
|
||
| ### How to modify the registry in Chromium-based browsers | ||
|
|
||
| :::warning | ||
|
|
||
| Administrator rights are required to edit the registry. Incorrect changes may affect system or browser stability and security. Always create a backup of the registry branch before modifying it. | ||
|
|
||
| Before proceeding, keep in mind that this solution reduces sandbox/AppContainer security, making the browser less isolated. It applies system-wide because it modifies `HKLM`, and should only be used for debugging, temporary workarounds, in controlled environments, or when TDI-based traffic interception is strictly necessary. | ||
|
|
||
| It should **not** be applied broadly across end-user machines. **Proceed only if you understand the implications.** | ||
|
|
||
| ::: | ||
|
|
||
| You can apply the necessary registry changes automatically by using one of the pre-generated .reg files below. Each file disables AppContainer/Network Service sandboxing for a specific Chromium-based browser: | ||
|
|
||
| - [Download Chrome.reg](https://cdn.adtidy.org/distr/windows/reg/DisableAppContainer_Chrome.reg) | ||
| - [Download Chromium.reg](https://cdn.adtidy.org/distr/windows/reg/DisableAppContainer_Chromium.reg) | ||
| - [Download Edge.reg](https://cdn.adtidy.org/distr/windows/reg/DisableAppContainer_Edge.reg) | ||
| - [Download Brave.reg](https://cdn.adtidy.org/distr/windows/reg/DisableAppContainer_Brave.reg) | ||
| - [Download Vivaldi.reg](https://cdn.adtidy.org/distr/windows/reg/DisableAppContainer_Vivaldi.reg) | ||
| - [Download YandexBrowser.reg](https://cdn.adtidy.org/distr/windows/reg/DisableAppContainer_YandexBrowser.reg) | ||
|
|
||
| If your browser is not listed, follow the manual instructions below to create the necessary registry entries: | ||
|
|
||
| 1. Determine its policy branch by checking the vendor’s official documentation or by opening the internal policy page. In Chrome, navigate to `chrome://policy`. Other browsers use a similar path. | ||
|
|
||
| 2. Identify the correct registry branch for your browser. Different Chromium-based browsers use different policy paths under `HKLM`. It should follow the model `HKLM\SOFTWARE\Policies\<Vendor>\<Product>`. | ||
|
|
||
| 3. Open the Registry Editor: | ||
|
|
||
| - Press _Win + R_ | ||
| - Type _regedit_ and press _Enter_ | ||
| - Approve the UAC prompt by running it as administrator | ||
|
|
||
| 4. Back up the Policies branch: | ||
|
|
||
| - In the left panel, navigate to `HKEY_LOCAL_MACHINE\SOFTWARE\Policies` | ||
| - Right-click _Policies_ → _Export_ | ||
| - Save the file as _Policies_backup.reg_ | ||
|
|
||
| If something goes wrong, you can restore the backup by double-clicking this file. | ||
|
|
||
| 5. Navigate to your browser’s policy key: | ||
|
|
||
| - Expand the path `HKEY_LOCAL_MACHINE` → _SOFTWARE_ → _Policies_. | ||
| - Locate the folder corresponding to your browser. | ||
|
|
||
| If the key does not exist, you can create it manually. Example for Chrome: | ||
|
|
||
| - Right-click _Policies_ → _New_ → _Key_ and name it `Google` | ||
| - Inside `Google`, create another key named `Chrome` | ||
|
|
||
| Repeat the same logic for Chromium, Edge, Brave, Vivaldi, Yandex Browser, etc. You should end up with a key that looks like `HKEY_LOCAL_MACHINE\SOFTWARE\Policies\<Vendor>\<Product>`. | ||
|
|
||
| 1. Add the required registry values: | ||
|
|
||
| - In the correct key, click the right panel → _New_ → _DWORD (32-bit) Value_ | ||
|
|
||
| - Name it `RendererAppContainerEnabled` | ||
|
|
||
| - Double-click it and set: | ||
|
|
||
| - **Value:** 0 | ||
| - **Base:** Hexadecimal or Decimal (either is fine) | ||
|
|
||
| - Repeat the process and create a second DWORD `NetworkServiceSandboxEnabled`. | ||
|
|
||
| - Set its value to 0. | ||
|
|
||
| Both parameters must be `REG_DWORD` and have the value **0**. | ||
|
|
||
| 2. Close the browser and apply the settings. To ensure the policy is loaded: | ||
|
|
||
| - Fully close the browser | ||
| - Check Task Manager and make sure no processes such as _chrome.exe_, _msedge.exe_, _brave.exe_ remain running | ||
| - Reopen the browser | ||
|
|
||
| 3. Verify that the policies have been applied by opening the policy viewer for your browser. | ||
|
|
||
| You should see the following policies active: | ||
|
|
||
| - `RendererAppContainerEnabled` — **0 / false** | ||
| - `NetworkServiceSandboxEnabled` — **0 / false** | ||
|
|
||
| If available, click _Reload policies_. | ||
|
|
||
| ¡Listo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file appears to be a Spanish translation (located in the i18n/es/ directory) but contains mostly English content with only a few Spanish phrases (lines 8-9 and 125). If this is intended to be a fully Spanish translation, the remaining English content should be translated.
| Cet article parle de AdGuard pour Windows, un bloqueur de contenus multifonctionnel qui protège votre appareil au niveau du système. To see how it works, [download the AdGuard app](https://agrd.io/download-kb-adblock). | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file appears to be only partially translated to French. While the file is in the French localization directory (i18n/fr/), only lines 8-9 (intro) and line 125 (conclusion) are in French. The rest of the document remains in English. Is this intentional, or should the entire document be translated?
|
Preview was deployed to: https://pull-request-799.kb-adg.pages.dev/ |
eebad87 to
b36cb0e
Compare
b36cb0e to
6d14553
Compare
|
Preview was deployed to: https://pull-request-799.kb-adg.pages.dev/ |
Transactions are synced from Crowdin