Skip to content

Conversation

@darbyjohnston
Copy link
Contributor

@darbyjohnston darbyjohnston commented Nov 1, 2025

This PR contains a couple of fixes for the C++ examples:

  • Modify the include directories to pickup the auto-generated version.h file
  • Use || instead of or in C++ code (I know or is technically correct, but Visual Studio still seems to have issues with it)
  • Fix a warning in examples\util.cpp about ignoring the return value from realpath
  • Enable the C++ examples in the CI so we can catch breaks sooner

Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
Signed-off-by: Darby Johnston <[email protected]>
@github-actions github-actions bot added the ci label Nov 1, 2025
@darbyjohnston darbyjohnston added the bug A problem, flaw, or broken functionality. label Nov 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.11%. Comparing base (30f6f56) to head (f903f5f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1967   +/-   ##
=======================================
  Coverage   85.11%   85.11%           
=======================================
  Files         181      181           
  Lines       12774    12774           
  Branches     1206     1206           
=======================================
  Hits        10872    10872           
  Misses       1719     1719           
  Partials      183      183           
Flag Coverage Δ
py-unittests 85.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f6f56...f903f5f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@darbyjohnston darbyjohnston added this to the Public Beta 18 milestone Nov 4, 2025
@darbyjohnston darbyjohnston merged commit 97ecf13 into AcademySoftwareFoundation:main Nov 4, 2025
56 checks passed
@darbyjohnston darbyjohnston deleted the cxx_examples_fix branch December 4, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A problem, flaw, or broken functionality. ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants