APPS-7761 Ruby Upgrade v3.1.0 (#425)

* Ruby version upgrade to 3.1.0

Author: zendesk-subhasish

.github/workflows/actions.yml

@@ -13,10 +13,8 @@ jobs:
     strategy:
       matrix:
         ruby-version:
-          - "2.7.5"
-          - "2.6.10"
-          - "2.6.9"
-          - "2.6.8"
+          - "3.1.0"
+          - "3.1.5"
     steps:
       - uses: zendesk/checkout@v3
       - uses: zendesk/setup-ruby@v1
@@ -30,7 +28,6 @@ jobs:
           key: ${{ runner.os }}-vendor-ruby-${{ matrix.ruby-version }}-lock-${{ hashFiles('Gemfile.lock') }}
           restore-keys: |
             ${{ runner.os }}-vendor-ruby-${{ matrix.ruby-version }}-
-            ${{ runner.os }}-vendor-
       - name: before_script
         run: |
           gem update --system 3.3.22

.ruby-version

@@ -1 +1 @@
-2.6.10
+3.1.0

Gemfile.lock

@@ -13,7 +13,7 @@ PATH
       sinatra-cross_origin (~> 0.3.1)
       thin (~> 1.8.0)
       thor (~> 0.19.4)
-      zendesk_apps_support (~> 4.38.2)
+      zendesk_apps_support (~> 4.39.0)
 
 GEM
   remote: https://rubygems.org/
@@ -167,9 +167,9 @@ GEM
     websocket-driver (0.7.5)
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
-    zendesk_apps_support (4.38.2)
+    zendesk_apps_support (4.39.0)
       erubis
-      i18n
+      i18n (>= 1.7.1)
       image_size (~> 2.0.2)
       ipaddress_2 (~> 0.13.0)
       json

lib/zendesk_apps_tools/command.rb

@@ -301,7 +301,7 @@ def download_scaffold(app_dir)
       begin
         require 'open-uri'
         require 'zip'
-        download = open(scaffold_url)
+        download = URI.open(scaffold_url)
         IO.copy_stream(download, tmp_download_name)
         zip_file = Zip::File.open(tmp_download_name)
         zip_file.each do |entry|

lib/zendesk_apps_tools/settings.rb

@@ -81,7 +81,7 @@ def parse_settings(filepath, contents)
           JSON.load(contents)
         else
           require 'yaml'
-          YAML.load(contents)
+          YAML.safe_load(contents)
         end
       settings_data.each do |index, setting|
         if setting.is_a?(Hash) || setting.is_a?(Array)

lib/zendesk_apps_tools/translate.rb

@@ -205,7 +205,7 @@ def en_yaml
         @en_yaml ||= begin
           path = "#{destination_root}/translations/en.yml"
           require 'yaml'
-          YAML.load_file(path) if File.exist? path
+          YAML.safe_load_file(path, permitted_classes: [Date]) if File.exist? path
         end
       end
 

spec/lib/zendesk_apps_tools/settings_spec.rb

@@ -79,8 +79,8 @@
         'not_required_with_default' => '789'
       }
 
-      allow(@user_input).to receive(:ask).with("Enter a value for required parameter 'required':\n", default: nil).and_return('xyz')
-      allow(@user_input).to receive(:ask).with("Enter a value for optional parameter 'not_required' or press 'Return' to skip:\n", default: nil).and_return('456')
+      allow(@user_input).to receive(:ask).with("Enter a value for required parameter 'required':\n", { default: nil }).and_return('xyz')
+      allow(@user_input).to receive(:ask).with("Enter a value for optional parameter 'not_required' or press 'Return' to skip:\n", { default: nil }).and_return('456')
       expect(@context.get_settings_from_user_input(parameters)).to eq(settings)
     end
   end

spec/lib/zendesk_apps_tools/translate_spec.rb

@@ -85,7 +85,7 @@
     it 'fetches default locales, translations and generates json files for each' do
       translate = ZendeskAppsTools::Translate.new
       allow(translate).to receive(:say)
-      allow(translate).to receive(:ask).with('What is the package name for this app? (without leading app_)', default: nil).and_return('my_app')
+      allow(translate).to receive(:ask).with('What is the package name for this app? (without leading app_)', { default: nil }).and_return('my_app')
       allow(translate).to receive(:create_file)
 
       expect(translate).to receive(:nest_translations_hash).once.and_return({})
@@ -103,7 +103,7 @@
     it 'fetches locales from a given locales file, translations and generates json files for each' do
       translate = ZendeskAppsTools::Translate.new
       allow(translate).to receive(:say)
-      allow(translate).to receive(:ask).with('What is the package name for this app? (without leading app_)', default: nil).and_return('my_app')
+      allow(translate).to receive(:ask).with('What is the package name for this app? (without leading app_)', { default: nil }).and_return('my_app')
       allow(translate).to receive(:create_file)
       allow(translate).to receive(:options) { { locales: './locales.json' } }
       allow(translate).to receive(:read_file).and_return('["en-ca.c68cff07da3c07bed9849e29aa7566d7"]')

zendesk_apps_tools.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |s|
   s.summary     = 'Tools to help you develop Zendesk Apps.'
   s.description = s.summary
 
-  s.required_ruby_version = '>= 2.6'
+  s.required_ruby_version = '>= 3.1.0'
   s.required_rubygems_version = '>= 3.0.0'
 
   s.add_runtime_dependency 'thor',        '~> 0.19.4'
@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'faraday',     '~> 0.17.5'
   s.add_runtime_dependency 'execjs',      '~> 2.7.0'
   s.add_runtime_dependency 'nokogiri',    '~> 1.13.10'
-  s.add_runtime_dependency 'zendesk_apps_support', '~> 4.38.2'
+  s.add_runtime_dependency 'zendesk_apps_support', '~> 4.39.0'
   s.add_runtime_dependency 'sinatra-cross_origin', '~> 0.3.1'
   s.add_runtime_dependency 'listen', '~> 2.10'
   s.add_runtime_dependency 'rack-livereload', '0.3.17'