Skip to content

Conversation

@charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Apr 21, 2025

since we have pycryptodome as a requirement, the sha3 import is dead. additionally, pysha3 is no longer maintained.

What I did

How I did it

How to verify it

Commit message

since we have `pycryptodome` as a requirement, the `sha3` import is
dead.  additionally, `pysha3` is no longer maintained.

`importlib.metadata` is no longer provisional as of Python3.10, so we
can remove the backported version.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

since we have `pycryptodome` as a requirement, the sha3 import is dead.
additionally, pysha3 is no longer maintained.
importlib.metadata is no longer provisional as of Python3.10, so we can
remove the backported version.
@socket-security
Copy link

socket-security bot commented Apr 21, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.70%. Comparing base (e4e9d7c) to head (ac9eb6c).
Report is 75 commits behind head on master.

Files with missing lines Patch % Lines
vyper/__init__.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4588      +/-   ##
==========================================
+ Coverage   92.68%   92.70%   +0.02%     
==========================================
  Files         123      123              
  Lines       17575    17570       -5     
  Branches     2988     2988              
==========================================
  Hits        16289    16289              
+ Misses        888      883       -5     
  Partials      398      398              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper changed the title chore[lang]: remove dead sha3 import chore[lang]: remove old backports Apr 22, 2025
@charles-cooper charles-cooper changed the title chore[lang]: remove old backports chore[lang]: remove dead imports Apr 22, 2025
@charles-cooper charles-cooper changed the title chore[lang]: remove dead imports chore[lang]: remove sha3 and importlib_metadata imports Apr 22, 2025
@charles-cooper charles-cooper merged commit d0e3e90 into vyperlang:master Apr 22, 2025
164 of 165 checks passed
@charles-cooper charles-cooper deleted the chore/remove-sha3 branch April 22, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants