Skip to content

Conversation

@charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 10, 2025

What I did

How I did it

How to verify it

Commit message

move `InstUpdater` to its own file and use it in more passes - it's
safer and faster for passes which use the `dfg` to modify it in place
using `InstUpdater`, rather than modifying instructions (without
updating the `dfg`), and then relying on a stale `dfg`.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title refactor[venom]: use InstUpdater everywhere refactor[venom]: use InstUpdater in more passes Mar 10, 2025
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.15%. Comparing base (ded6b2c) to head (a520fa6).
Report is 85 commits behind head on master.

Files with missing lines Patch % Lines
vyper/venom/passes/machinery/inst_updater.py 93.47% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4508      +/-   ##
==========================================
- Coverage   92.16%   92.15%   -0.02%     
==========================================
  Files         122      123       +1     
  Lines       17471    17469       -2     
  Branches     2959     2957       -2     
==========================================
- Hits        16103    16099       -4     
- Misses        957      958       +1     
- Partials      411      412       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper requested review from HodanPlodky and harkal and removed request for harkal March 11, 2025 11:30

def run_pass(self):
self.dfg = self.analyses_cache.request_analysis(DFGAnalysis)
self.updater = InstUpdater
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not this consume the dfg/call constructor?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, looks like it's not actually used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charles-cooper charles-cooper merged commit 41108f9 into vyperlang:master Mar 12, 2025
162 checks passed
@charles-cooper charles-cooper deleted the refactor/venom/inst-updater branch March 12, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants