refactor[venom]: replace bb.mark_for_removal with make_nop
#4474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is slightly cleaner, since we don't need to remember to call `bb.clear_dead_instructions()` after `mark_for_removal()`, instead they will all be removed in one go whenever `RemoveUnusedVariablesPass` runs.
harkal
approved these changes
Feb 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4474 +/- ##
==========================================
- Coverage 92.12% 92.11% -0.02%
==========================================
Files 119 119
Lines 16969 16965 -4
Branches 2872 2873 +1
==========================================
- Hits 15633 15627 -6
- Misses 918 920 +2
Partials 418 418 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is slightly cleaner, since we don't need to remember to call
bb.clear_dead_instructions()aftermark_for_removal(), instead they will all be removed in one go wheneverRemoveUnusedVariablesPassruns.What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture