-
-
Notifications
You must be signed in to change notification settings - Fork 871
refactor[venom]: add new venom test machinery #4401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[venom]: add new venom test machinery #4401
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4401 +/- ##
===========================================
- Coverage 91.11% 50.92% -40.20%
===========================================
Files 115 115
Lines 16225 16227 +2
Branches 2728 2729 +1
===========================================
- Hits 14784 8264 -6520
- Misses 1006 7345 +6339
- Partials 435 618 +183 ☔ View full report in Codecov by Sentry. |
| s += opcode | ||
| operands = self.operands | ||
| if opcode not in ["jmp", "jnz", "invoke"]: | ||
| if opcode not in ("jmp", "jnz", "invoke"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now this is not necessarily part of the PR but there it should be self.opcode no? since the opcode contains space after original opcode so body of this if is unreachable right now (I have noticed it when thinking about order of operands in jnz)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: HodanPlodky <[email protected]>
What I did
refactor venom tests with new parsing machinery. it should make tests easier to read. add an example of the new testing style
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture