Skip to content

Commit 3b310d5

Browse files
chore(ci): fix binary names in release asset upload (#3597)
rename binary during asset upload to properly escape the filename for the github API call. (Github API states: > GitHub renames asset filenames that have special characters, non-alphanumeric characters, and leading or trailing periods. The "List release assets" endpoint lists the renamed filenames. For more information and help, contact GitHub Support. )
1 parent 0cb37e3 commit 3b310d5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ jobs:
100100
-X POST \
101101
-H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}"\
102102
-H "Content-Type: application/octet-stream" \
103-
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=${BIN_NAME}" \
103+
"https://uploads.github.com/repos/${{ github.repository }}/releases/${{ github.event.release.id }}/assets?name=${BIN_NAME/+/%2B}" \
104104
--data-binary "@${BIN_NAME}"
105105
done
106106

0 commit comments

Comments
 (0)