When no argument is passed to the .click interaction command, the webdriver command should also have no argument

Indeed webdriver.io has a different behavior when the argument is not
undefined.

Fixes #8931

Author: julienw

packages/browser-webdriverio/src/commands/click.ts

@@ -4,16 +4,16 @@ import type { UserEventCommand } from './utils'
 export const click: UserEventCommand<UserEvent['click']> = async (
   context,
   selector,
-  options = {},
+  options,
 ) => {
   const browser = context.browser
-  await browser.$(selector).click(options as any)
+  await browser.$(selector).click(options)
 }
 
 export const dblClick: UserEventCommand<UserEvent['dblClick']> = async (
   context,
   selector,
-  _options = {},
+  _options,
 ) => {
   const browser = context.browser
   await browser.$(selector).doubleClick()
@@ -22,7 +22,7 @@ export const dblClick: UserEventCommand<UserEvent['dblClick']> = async (
 export const tripleClick: UserEventCommand<UserEvent['tripleClick']> = async (
   context,
   selector,
-  _options = {},
+  _options,
 ) => {
   const browser = context.browser
   await browser

packages/browser/src/client/tester/locators/index.ts

@@ -74,15 +74,15 @@ export abstract class Locator {
     })
   }
 
-  public click(options: UserEventClickOptions = {}): Promise<void> {
+  public click(options?: UserEventClickOptions): Promise<void> {
     return this.triggerCommand<void>('__vitest_click', this.selector, options)
   }
 
-  public dblClick(options: UserEventClickOptions = {}): Promise<void> {
+  public dblClick(options?: UserEventClickOptions): Promise<void> {
     return this.triggerCommand<void>('__vitest_dblClick', this.selector, options)
   }
 
-  public tripleClick(options: UserEventClickOptions = {}): Promise<void> {
+  public tripleClick(options?: UserEventClickOptions): Promise<void> {
     return this.triggerCommand<void>('__vitest_tripleClick', this.selector, options)
   }
 

test/browser/test/userEvent.test.ts

@@ -23,12 +23,21 @@ describe('userEvent.click', () => {
     document.body.appendChild(button)
     const onClick = vi.fn()
     const dblClick = vi.fn()
+    const onContextmenu = vi.fn()
     button.addEventListener('click', onClick)
+    button.addEventListener('dblclick', onClick)
+    button.addEventListener('contextmenu', onContextmenu)
 
     await userEvent.click(button)
 
     expect(onClick).toHaveBeenCalled()
     expect(dblClick).not.toHaveBeenCalled()
+    expect(onContextmenu).not.toHaveBeenCalled()
+
+    onClick.mockClear()
+    await userEvent.click(button, { button: 'right' })
+    expect(onClick).not.toHaveBeenCalled()
+    expect(onContextmenu).toHaveBeenCalled()
   })
 
   test('correctly doesn\'t click on a disabled button', async () => {