-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: emit QueryExecutionsByTable for success cases only #18584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18584 +/- ##
==========================================
- Coverage 67.52% 67.49% -0.03%
==========================================
Files 1607 1607
Lines 263324 263325 +1
==========================================
- Hits 177803 177737 -66
- Misses 85521 85588 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| // TestMetricForExplain verifies that query metrics are correctly published for explain queries. | ||
| func TestMetricForExplain(t *testing.T) { | ||
| ctx := context.Background() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nit-picking.
| ctx := context.Background() | |
| ctx := t.Context() |
Description
This PR stops emitting QueryExecutionsByTable metrics on error cases.
Related Issue(s)
Checklist
Deployment Notes