Skip to content

Conversation

@shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Apr 6, 2025

Description

This PR introduces two new queries:

  • alter vitess_migration '<uuid>' postpone complete
  • alter vitess_migration postpone complete all

With these two queries, it is possible to set postpone_completion on already running migrations that are not postponed. The use case in particular is for when a migration seems to run into an endless cut-over sequence and is unable to complete. It may be desired to withhold completion until further notice.

These commands are the opposite of alter vitess_migration ... complete [all] commands, and can alternate back and forth multiple times in the lifetime of the migration.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Apr 6, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 6, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 6, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Apr 6, 2025
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 6, 2025
@codecov
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 67.45%. Comparing base (9e734f8) to head (dde5696).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/onlineddl/executor.go 0.00% 46 Missing ⚠️
go/vt/sqlparser/ast_format.go 0.00% 4 Missing ⚠️
go/vt/vttablet/tabletserver/query_executor.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18118      +/-   ##
==========================================
- Coverage   67.53%   67.45%   -0.09%     
==========================================
  Files        1601     1601              
  Lines      261484   262150     +666     
==========================================
+ Hits       176592   176828     +236     
- Misses      84892    85322     +430     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shlomi-noach shlomi-noach changed the title Online DDL: support alter vitess_migration ... postpone syntax Online DDL: support alter vitess_migration ... postpone complete syntax Apr 6, 2025
@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented Apr 6, 2025

Changed syntax from alter vitess_migration ... postpone to alter vitess_migration ... postpone complete for consistency with --postpone-complete ddl strategy flag.

Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: Deepthi Sigireddi <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach
Copy link
Contributor Author

Docs PR: vitessio/website#1991

@shlomi-noach shlomi-noach removed the NeedsWebsiteDocsUpdate What it says label Apr 29, 2025
@shlomi-noach shlomi-noach merged commit 1bbbcda into vitessio:main Apr 29, 2025
103 of 107 checks passed
@shlomi-noach shlomi-noach deleted the online-ddl-alter-postpone branch April 29, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for stopping OnlineDDL complete

3 participants