Skip to content

VReplication: Add reference-tables to existing materialize workflow #17804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohit-nayak-ps merged 14 commits into from
Apr 24, 2025

Merge main and fix conflicts

2e7e19e
Select commit
Loading
Failed to load commit list.
Merged

VReplication: Add reference-tables to existing materialize workflow #17804

Merge main and fix conflicts
2e7e19e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 24, 2025 in 1s

67.50% (-0.05%) compared to 673e0d3

View this Pull Request on Codecov

67.50% (-0.05%) compared to 673e0d3

Details

Codecov Report

Attention: Patch coverage is 68.72852% with 91 lines in your changes missing coverage. Please review.

Project coverage is 67.50%. Comparing base (673e0d3) to head (2e7e19e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/server.go 77.77% 34 Missing ⚠️
...nt/command/vreplication/materialize/materialize.go 16.66% 20 Missing ⚠️
go/vt/vtctl/workflow/materializer.go 82.95% 15 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 0.00% 12 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 5 Missing ⚠️
...vttablet/tabletmanager/vreplication/vreplicator.go 50.00% 3 Missing ⚠️
go/vt/vtctl/localvtctldclient/client_gen.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17804      +/-   ##
==========================================
- Coverage   67.54%   67.50%   -0.05%     
==========================================
  Files        1601     1601              
  Lines      261484   261816     +332     
==========================================
+ Hits       176612   176726     +114     
- Misses      84872    85090     +218

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov