Skip to content

LookupVindex: Multiple lookup tables support for LookupVindexCreate #17566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohit-nayak-ps merged 23 commits into from
Apr 24, 2025
Merged

LookupVindex: Multiple lookup tables support for LookupVindexCreate #17566

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
c9e74bf
LookupVindex: Multiple lookup tables support for LookupVindexCreate
beingnoble03 Jan 17, 2025
af6c741
test: Fix failing unit tests
beingnoble03 Jan 17, 2025
86d4cd9
Remove unnecessary code
beingnoble03 Jan 20, 2025
9133e84
Clean code and abstract into common functions
beingnoble03 Jan 28, 2025
fcb540b
Merge main into lv-multiple-tables
beingnoble03 Jan 28, 2025
447cf1b
test: Add unit test for multiple lookup vindex create
beingnoble03 Feb 3, 2025
1215cd6
Merge prepareCreate and prepareMultipleCreate into a single function
beingnoble03 Feb 26, 2025
d469c33
Merge main into lv-multiple-tables
beingnoble03 Feb 26, 2025
b703d14
Remove proto message used for unmarshalling
beingnoble03 Feb 27, 2025
ff0f1ef
Fix error message and typos
beingnoble03 Feb 27, 2025
4921626
Clean unnecessary code
beingnoble03 Feb 27, 2025
f8441fa
Add lokup vindexes to workflow options & restructure lv commands for …
beingnoble03 Mar 16, 2025
03f9dba
Merge main into lv-multiple-tables
beingnoble03 Mar 16, 2025
cbc1125
Support old behaviour and fix unit tests
beingnoble03 Mar 16, 2025
54b2c39
test: Add unit tests for mulitple lv externalize, internalize and com…
beingnoble03 Mar 17, 2025
32c31e4
Merge branch 'main' into lv-multiple-tables
beingnoble03 Mar 17, 2025
6a69b0f
Fix import error in keyspace_shard_discovery.go
beingnoble03 Mar 17, 2025
fbaa1bf
Merge branch 'fix-sync-import' into lv-multiple-tables
beingnoble03 Mar 17, 2025
f522479
test: Update from and to params in unit tests
beingnoble03 Mar 22, 2025
19c1394
Minor validations and comment improvements
beingnoble03 Mar 22, 2025
51983a3
Merge main and fix conflicts
beingnoble03 Apr 24, 2025
5fa8fce
Trigger CI
beingnoble03 Apr 24, 2025
a4dc1cf
Merge main and fix conflicts
beingnoble03 Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions go/vt/vtctl/workflow/materializer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2541,20 +2541,6 @@ func TestCreateLookupVindexFailures(t *testing.T) {
schemaAdditions []*tabletmanagerdatapb.TableDefinition
err string
}{
{
description: "dup vindex",
input: &vschemapb.Keyspace{
Vindexes: map[string]*vschemapb.Vindex{
"v1": {
Type: "xxhash",
},
"v2": {
Type: "xxhash",
},
},
},
err: "only one vindex must be specified",
},
{
description: "not a lookup",
input: &vschemapb.Keyspace{
Expand Down Expand Up @@ -2633,7 +2619,7 @@ func TestCreateLookupVindexFailures(t *testing.T) {
input: &vschemapb.Keyspace{
Vindexes: unique,
},
err: "one or two tables must be specified",
err: "atleast one table must be specified",
},
{
description: "too many tables",
Expand Down
Loading